[Webkit-unassigned] [Bug 61346] --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 1 14:52:54 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=61346
--- Comment #28 from Darin Adler <darin at apple.com> 2011-08-01 14:52:55 PST ---
(From update of attachment 102554)
View in context: https://bugs.webkit.org/attachment.cgi?id=102554&action=review
Not doing a review, but I do have a couple small formatting comments.
> Source/WebCore/editing/visible_units.cpp:1179
> + return blockDirection == LTR ? !box->nextLeafChild() || box->nextLeafChild()->renderer()->isBR() :
> + !box->prevLeafChild() || box->prevLeafChild()->renderer()->isBR();
Our normal formatting is to put the ":" on the new line, not on the end of the previous line.
> Source/WebCore/editing/visible_units.cpp:1371
> + int offsetOfEndOfBlock;
Seems you should define this just before using it, not at the top of the function.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list