[Webkit-unassigned] [Bug 61346] --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61346


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102219|review?                     |review-
               Flag|                            |




--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-01 13:44:40 PST ---
(From update of attachment 102219)
View in context: https://bugs.webkit.org/attachment.cgi?id=102219&action=review

> Source/WebCore/editing/visible_units.cpp:1179
> +                                   !box->prevLeafChild() || box->prevLeafChild()->renderer()->isBR();

Nit: We don't align second lines like this.  This line should be intended by 4 spaces in addition to the 4 spaces in front of "return".

>> Source/WebCore/editing/visible_units.cpp:1402
>> +    
> 
> the above 2 newly added code pieces are similar, maybe they could be combined as one function? and logical of isBoxVisuallyLastInLine can be moved inside the function as well.

I agree with Xiaomei here.  We should at least create a function for the code inside the if.  r- because of this code duplication.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.