[Webkit-unassigned] [Bug 65458] REGRESSION(r92092): Build fails on 64 bit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65458





--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2011-08-01 13:24:16 PST ---
(In reply to comment #1)
> Created an attachment (id=102514)
 --> (https://bugs.webkit.org/attachment.cgi?id=102514&action=review) [details]
> preliminary patch
> 
> This patch fixes the compile assert but it cause an infinite loop as it creates a block with cellSize 0. There is some hidden dependency between the blocks and values.
> 
> Geoff, any idea?

The issue is with the logic in sizeClassFor().  The preciseCutoff is actually the smallest allocation size for imprecise size classes, rather than the upper bound on sizes for precise size classes.  So for example in the current scheme, a 120 byte allocation should be allocated as 128 bytes, and so it should go to an imprecise size class.  So the number of size classes is not wrong, but the selection algorithm is.

I've got a patch for this and am testing it now...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.