[Webkit-unassigned] [Bug 64734] [Qt] Out-of-tree build using make-package.py is broken

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 10:52:34 PDT 2011


--- Comment #10 from Alexis Menard <alexis.menard at openbossa.org>  2011-08-01 10:52:34 PST ---
(In reply to comment #9)
> (In reply to comment #5)
> > (From update of attachment 101175 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=101175&action=review
> > 
> > This patch was tested outside the make-package case? Normal build with build-webkit --qt --release and WEBKIT_OUTPUT_DIR=/my/path build-webkit --qt --release. What about inside Qt?
> > 
> > > Source/WebKit/qt/Api/DerivedSources.pro:47
> > > +    CONFIG(standalone_package): PATH_TO_HEADER = ../../Source/WebKit/qt/Api/$$basename(HEADER)
> > 
> > As I said on IRC, I don't think this is a good idea. How this will work with let say shadow build.
> No, that was a different issue (or not?). This change doesn't move the generated headers at all. It just changes the content of those headers to refer to an existing path. Currently they'd point to "../../WebKit" which would be a root-level WebKit folder, which doesn't exist after running make-package.py

Could you apply it on the 4.8 branch and test to see if it doesn't break anything?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list