[Webkit-unassigned] [Bug 65311] [EFL] Replace strerror with strerror_r.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 07:41:09 PDT 2011


Lucas De Marchi <demarchi at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #102247|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #7 from Lucas De Marchi <demarchi at webkit.org>  2011-08-01 07:41:08 PST ---
(From update of attachment 102247)
View in context: https://bugs.webkit.org/attachment.cgi?id=102247&action=review

> Source/WebKit/efl/ewk/ewk_tiled_private.h:35
> +#define OOM(op, size) \
> +    char buf[256]; \
> +    CRITICAL("could not %s %zd bytes: %s", op, size, strerror_r(errno, buf, sizeof(buf)))
> +

Besides what Raphael said, this is wrong. See this piece of code:

int function(void)
    char *buf;

    buf = malloc(200);
    if (!buf)
        OOM("allocate", 200);

Bang... you get a compiler error: `error: expected expression before ‘char’'

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list