[Webkit-unassigned] [Bug 58013] [Chromium] Needs eventSender.scalePageBy()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58013


Kentaro Hara <haraken at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102370|1                           |0
        is obsolete|                            |




--- Comment #7 from Kentaro Hara <haraken at google.com>  2011-08-01 01:33:06 PST ---
(From update of attachment 102370)
View in context: https://bugs.webkit.org/attachment.cgi?id=102370&action=review

>> LayoutTests/ChangeLog:21
>> +        * platform/chromium/test_expectations.txt: Enabled three tests.
> 
> It seems we need new expectation files for the followings on chromium-mac and chromium-win.
> 
> compositing/scaling/tiled-layer-recursion.txt
> repaint/scale-page-shrink.html
> fast/dom/Element/scale-page-bounding-client-rect.html
> fast/dom/Range/scale-page-client-rect.html
> 
> Removing wrong expectations is ok, but removing entries in test_expectations.txt wil break the tests because of lack of correct expectations.

I added the lines for tiled-layer-recursion.html and scale-page-shrink.html to test_expectations.txt. 

There is no need for scale-page-bouding-client-rect.html and scale-page-client-rect.html, since the results for these two tests are now equivalent to the results in LayoutTests/fast/dom/.

>> Source/WebKit/chromium/public/WebView.h:209
>> +    virtual void scalePageBy(float scaleFactor, float x, float y) = 0;
> 
> Changing public interface only for DumpRenderTree should be avoided.
> Can you move EventSender.scalePageBy() to window.internals.scalePageBy() ?

We need to reset the page scale at the head of each DumpRenderTree test. Specifically, we need to reset the page scale in TestShell::resetTestController(). Since DumpRenderTree should not access WebCore::Frame::scalePage() directly, I think that the public API for scalePageBy() is required.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.