[Webkit-unassigned] [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53625


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88947|review?                     |review+
               Flag|                            |




--- Comment #21 from Daniel Bates <dbates at webkit.org>  2011-04-10 00:03:03 PST ---
(From update of attachment 88947)
View in context: https://bugs.webkit.org/attachment.cgi?id=88947&action=review

This patch is OK. That being said, we will also need to update svn-unapply and, if possible, add unit tests for this change. Towards this, we should look to extract the file EOL logic into a function in VCSUtils.pm so that it can be shared by both svn-apply/unapply.

I suggest that we add a FIXME comment above your change to indicate that we should add similar functionality to svn-unapply and/or extract some of this code and move it to VCSUtils.pm.

> Tools/Scripts/svn-apply:339
> +                # Think of it as escaping. Patch will convert \r\n to \n, so \r\r\n becomes \r\n.

Nit: Patch => Patch(1)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.