[Webkit-unassigned] [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53625





--- Comment #18 from Daniel Bates <dbates at webkit.org>  2011-04-09 23:30:46 PST ---
(In reply to comment #17)
> (In reply to comment #14)
> >  The patch is incorrect and will break svn-apply/unapply for all people with an SVN checkout on a Unix file system (this includes SVN under a default installation of Cygwin). ...
> 
> Thanks for the info. Rolled out. http://trac.webkit.org/changeset/83395
> 
> I suppose patch could be more sophisticated to look at the very first line ending of the file and use that to decided if we are dealing with DOS endings or not.

I take it you mean svn-apply not patch. Yes, this is the approach I'm taking.

> 
> Would that work?

I believe it will work.

> 
> I really want to get this fixed as I hear about people hitting this often enough (and then I get pings to help land patches....)

I agree. For completeness, I am currently working on a fix for this issue and hope to post it tomorrow (04/10) / Monday. That being said, I would prefer we fix this as soon as possible. So, feel free to post an updated patch or a temporary workaround that we can use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.