[Webkit-unassigned] [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53625


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #14 from Daniel Bates <dbates at webkit.org>  2011-04-09 23:07:59 PST ---
I know this patch has already been reviewed and landed in <http://trac.webkit.org/changeset/83394>.

I wanted to add some remarks. The patch is incorrect and will break svn-apply/unapply for all people with an SVN checkout on a Unix file system (this includes SVN under a default installation of Cygwin). This is because the Visual Studio project files have been checked into the repository with Unix line endings and have svn:eol-style: native. So, these files will have Unix new lines in an SVN checkout on a Unix file system.

Note, this patch will fix the issue for people who use Git version greater than 1.7.0.3. Since the commit/EWS bots seem to using this version of Git, this patch will resolve the issue. At the very least, there should be a FIXME comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.