[Webkit-unassigned] [Bug 59752] Allow Localized Date Strings for Date Input Fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59752


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91632|review?                     |review-
               Flag|                            |




--- Comment #12 from Kent Tamura <tkent at chromium.org>  2011-04-29 15:58:53 PST ---
(From update of attachment 91632)
View in context: https://bugs.webkit.org/attachment.cgi?id=91632&action=review

> Source/WebCore/ChangeLog:27
> +        (WebCore::BaseDateAndTimeInputType::serialize):
> +        (WebCore::BaseDateAndTimeInputType::serializeWithComponents):
> +        serializing for a double value may be different for different
> +        types. The month type assumes it is monthes instead of msecs
> +        like the others. So provide a more general serialization
> +        function that will always serialize a string correctly for
> +        the current type but from a DateComponents object. Useful
> +        when we create our own DateComponents object from the msec
> +        value returned from a LocalizedDate implementation.

I don't think this change is needed.  BaseDateAndTimeInputType::serialize(double) already handle the month type correctly.

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:208
> +    if (!date.setMillisecondsSinceEpochForDateTime(parsedValue))

This is wrong.  It sets DateTime type to the DateComponents object.  I think serialize(parsedValue) is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.