[Webkit-unassigned] [Bug 54929] REGRESSION: Text selection broken for text with line-height applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54929





--- Comment #18 from Ojan Vafai <ojan at chromium.org>  2011-04-29 15:15:16 PST ---
(From update of attachment 85560)
View in context: https://bugs.webkit.org/attachment.cgi?id=85560&action=review

>>> Source/WebCore/rendering/RenderBlock.cpp:4077
>>> +        IntPoint point(pointInLogicalContents.x(), closestBox->isText() ? closestBox->root()->selectionTop() : closestBox->logicalHeight());
>> 
>> The selectionTop of the rootlinebox is not necessarily inside the closestBox, is it? As in, what if the closestBox is on the second line?
> 
> The RootInlineBox always owns just one line, so it'll always contain its InlineBox children.

Heh. Whoops. Wrapping was a bad example. A better example is the following:
<span style="border:2px solid lawngreen">
    <span style="border:1px solid blue;font-size:20em">foo</span>
    <span style="border:1px solid red;">bar</span>
</span>

If you click to the right of foo, but above bar, don't we pass the wrong value, e.g., we could pass a value that's below the bottom of the box.

Also, why change logicalTop to logicalHeight in the non-isText case?

Sorry, my knowledge of the RenderTree and LineBox trees isn't good enough to know the answers to these off the top of my head.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.