[Webkit-unassigned] [Bug 58210] webkit should implement the dropzone attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58210





--- Comment #20 from Yael <yael.aharon at nokia.com>  2011-04-29 15:05:49 PST ---
(In reply to comment #19)
> (From update of attachment 91672 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91672&action=review
> > Source/WebCore/page/EventHandler.cpp:1792
> > +            if (matched && dragOperation != DragOperationNone)
> > +                break;
> 
> Can we check this condition inside if (dragOperation == DragOperationNone) instead?  That'll make the purpose of early exit much clear.
> 
> > Source/WebCore/page/EventHandler.cpp:1797
> > +                if (dragOperation == DragOperationNone)
> > +                    dragOperation = op;
> 
> So you do:
> if (dragOperation == DragOperationNone) {
>     dragOperation = op;
>     if (matched)
>         break;
> }
> 
I'll move the condition as you asked, but please note that there are 3 conditions that require me to break and I have to allow all of them :
1. operation is defined before type
2. type is defined before operation
3. operation is not defined at all.

> > LayoutTests/fast/events/dropzone-002.html:43
> > +    function changeDropZone()
> > +    {
> > +        dropTarget.setAttribute("dropzone", dropEffectElem.options[dropEffectElem.selectedIndex].value + " s:text/plain");
> > +    }
> > +
> > +    function drop(e)
> > +    {
> > +        printDropEvent(e);
> > +        cancelDrag(e);
> > +    }
> 
> Can we add a new js file in resources and share all of these functions across tests?

Only 2 functions are shared between all the files and can be isolated. All the other functions have small different differences. I'll separate out 
drop() and cancelDrag().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.