[Webkit-unassigned] [Bug 58837] Fieldset disabled attribute does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58837





--- Comment #19 from Darin Adler <darin at apple.com>  2011-04-29 10:53:33 PST ---
I don’t think rare data is relevant here. For the record, the cost of adding new rare data is:

    1) Every nodes with rare data uses a bit more memory.
    2) If this adds rare data to more nodes, then memory use goes up by a lot because all other rare data is allocated for each node, too.

But having a pointer to the fieldset from every form element is not the right way to go about this. Instead, when a fieldset is disabled we should iterate all the form items in the fieldset and tell them its state has changed. Then the form items would only need a single bit to keep track of whether the fieldset is disabled.

Similarly we need to detect when DOM manipulations change which fieldset a form element is in.

We need to do more than just return the right value from the disabled function; there is work to do at the time the disabled state changed. We need to trigger the appropriate style recalculation. Actively toggling a flag may is probably the best way to get the code right.

The code in the patch is not really close to right yet, because it doesn’t deal with the style recalculation issue at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.