[Webkit-unassigned] [Bug 59721] REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59721


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91619|review?                     |review+
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2011-04-29 10:44:48 PST ---
(From update of attachment 91619)
View in context: https://bugs.webkit.org/attachment.cgi?id=91619&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.h:45
> +- (BOOL)maintainsInactiveSelection;

Does this need to be in the header file? Normally, we don’t have to declare methods if we’re just overriding something in NSView. We only need to put the method in the header if it’s a new method that some other class is going to call.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:318
> +    if (![self maintainsInactiveSelection])
> +        _data->_page->clearSelection();

Is there a good reason to call maintainsInactiveSelection here? It’s just a function that always returns NO.

Do we expect people to make subclasses of WKView and override the maintainsActiveSelection method?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:564
> +- (BOOL)maintainsInactiveSelection
> +{
> +    return false;
> +}

For BOOL it’s YES and NO. The values false and true are of type bool.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.