[Webkit-unassigned] [Bug 52211] FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52211





--- Comment #8 from Joe Mason <jmason at rim.com>  2011-04-29 09:46:52 PST ---
(In reply to comment #7)
> The name shouldDumpUserGestureInFrameLoadCallbacks(), in particular the suffix "InFrameLoadCallbacks", implies to me that we should only print the user gesture status when both shouldDumpFrameLoadCallbacks() and shouldDumpUserGestureInFrameLoadCallbacks() evaluates to true. That is, a code structure similar to:
> 
> if (!m_shell->shouldDumpFrameLoadCallbacks())
>      return;
> printFrameDescription(frame);
> ...
> if (m_shell->shouldDumpUserGestureInFrameLoadCallbacks())
>     printFrameUserGestureStatus(frame, " - in willPerformClientRedirect\n");

I disagree.  This isn't how the existing uses of shouldDumpUserGestureInFrameLoadCallbacks are structured.  See FrameLoaderClientQt::dispatchDidStartProvisionalLoad() for instance:

     if (dumpFrameLoaderCallbacks)
         printf("%s - didStartProvisionalLoadForFrame\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame)));

     if (dumpUserGestureInFrameLoaderCallbacks)
         printf("%s - in didStartProvisionalLoadForFrame\n", qPrintable(drtPrintFrameUserGestureStatus(m_frame)));

Treating it differently in willPerformClientRedirect() would be inconsistent, and changing it for all cases is out of scope of this bug.

I will update the comments and put up a new patch this weekend.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.