[Webkit-unassigned] [Bug 59776] Sometimes WebKit2 pauses during launch due to waiting for the first render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59776


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91635|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-04-29 09:34:19 PST ---
(From update of attachment 91635)
View in context: https://bugs.webkit.org/attachment.cgi?id=91635&action=review

>> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80
>> +        if(!m_hasReceivedFirstUpdate)
> 
> Missing space before ( in if(  [whitespace/parens] [5]

I agree with the style bot.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:188
> +    else if (!m_hasReceivedFirstUpdate)
> +        m_hasReceivedFirstUpdate = true;

No need for the if statement here. You don’t have to check a boolean is false before setting it to true.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102
> +    // For the first draw, don't draw anything until the WebProcess has sent over the bits.

This comment says “for the first draw”, but the code affects more than just the first draw, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.