[Webkit-unassigned] [Bug 56705] [CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 29 07:10:53 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56705





--- Comment #15 from Lucas De Marchi <demarchi at webkit.org>  2011-04-29 07:10:52 PST ---
(In reply to comment #14)
> http://trac.webkit.org/browser/trunk/Source/WebCore/CMakeListsEfl.txt isn't a simple file list. There are _conditional_ lists (e.g. IF(WTF_USE_CAIRO)) and it also contains a ADD_DEFINITIONS. 

IMO conditional lists are fine because they are still lists. Where to turn on and off the options (the logic) is still in another file, which seems right.

Maybe the ADD_DEFINITIONS would be a thing to put in another file.

> http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/CMakeListsWinCE.txt defines the generation of the asm files.

Same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list