[Webkit-unassigned] [Bug 56705] [CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56705





--- Comment #13 from Ryuan Choi <ryuan.choi at samsung.com>  2011-04-28 18:10:22 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > Patrick: why do we want this? 
> > 
> > To make the build system more CMake style.
> > You usually have _one_ CMakeLists.txt in you build directory. Additional stuff is usually in "XXX.cmake" files.
> > See the source of CMake itself: http://cmake.org/gitweb?p=cmake.git;a=tree
> 
> But there they are additional "logical" stuff to the build system. Here they are additional _file lists_ to be added.
> 
This bug have little history from Bug 56624.
I already add UseJSC.cmake for JSC and prepare UseV8.cmake.
those files are also additional file lists to be added as an option(now UseJSC only supported).

IMO, we can give more information using Platform${PORT}.cmake and Use${OPTION}.cmake instead of CMakeLists${PORT}.txt and CMakeLists${OPTION}.txt

> 
> > Many editors will provide correct syntax highlighting, because most of them match "CMakeLists.txt|*.cmake".
> 
> Here Vim does provides the highlighting in CMakeListsEfl.txt. It's just a matter of configuring another pattern in you editor's options.
> 
Strange, Vim on My PC can't

> > 
> > > Now I'd need to grep the .cmake files too. What's the point with renaming them?
> > 
> > When do you grep the files? Why?
> 
> Usually when I'm checking what files are in each list, i.e. when I'm figuring out why it works in GTK (then I grep Makefile.am files) and not in EFL (then I grep CMakeLists*.txt file)... or vice-versa.
> 
> But my point here is that they are file lists. For me it makes sense to name them the way they are now.

Now, We should search CMakeLists.txt, CMakeLists${PORT}.txt and UseJSC.cmake(and UseV8.cmake if needed) for checking all files to build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.