[Webkit-unassigned] [Bug 59752] Allow Localized Date Strings for Date Input Fields

Thu Apr 28 16:42:05 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59752

--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-04-28 16:42:06 PST ---
(From update of attachment 91579)
View in context: https://bugs.webkit.org/attachment.cgi?id=91579&action=review

> LayoutTests/fast/forms/date-input-visible-strings.html:1
> +<!DOCTYPE html>

Please add sentences describing the expected result.  e.g. "the user-visible values of the input fields should be localized if the platform has a LocalizedDate implementation. Otherwise, they should be in the HTML5 formats."

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22989
>  				F3810C1E1365A4D400ED6E33 /* WorkerContextInspectorProxy.h in Headers */,
> +				A5732B0B136A161D005C8D7C /* DateComponents.h in Headers */,
> +				A5732B0D136A16C4005C8D7C /* LocalizedDate.h in Headers */,

nit: They should be inserted to sorted positions.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25688
>  				781755861365A1B00093BE2E /* DataTransferItems.cpp in Sources */,
> +				A5732B0A136A161D005C8D7C /* DateComponents.cpp in Sources */,
> +				A5732B0F136A1715005C8D7C /* LocalizedDateNone.cpp in Sources */,

ditto.

> Source/WebCore/platform/text/LocalizedDate.h:37
> +String formatLocalizedDate(const DateComponents& dateComponents);

This only has a format function.  What about parsing?
Showing a localized string but accepting no localized string is not good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.