[Webkit-unassigned] [Bug 56705] [CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56705





--- Comment #12 from Lucas De Marchi <demarchi at webkit.org>  2011-04-28 15:31:55 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > Patrick: why do we want this? 
> 
> To make the build system more CMake style.
> You usually have _one_ CMakeLists.txt in you build directory. Additional stuff is usually in "XXX.cmake" files.
> See the source of CMake itself: http://cmake.org/gitweb?p=cmake.git;a=tree

But there they are additional "logical" stuff to the build system. Here they are additional _file lists_ to be added.


> Many editors will provide correct syntax highlighting, because most of them match "CMakeLists.txt|*.cmake".

Here Vim does provides the highlighting in CMakeListsEfl.txt. It's just a matter of configuring another pattern in you editor's options.

> 
> > Now I'd need to grep the .cmake files too. What's the point with renaming them?
> 
> When do you grep the files? Why?

Usually when I'm checking what files are in each list, i.e. when I'm figuring out why it works in GTK (then I grep Makefile.am files) and not in EFL (then I grep CMakeLists*.txt file)... or vice-versa.

But my point here is that they are file lists. For me it makes sense to name them the way they are now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.