[Webkit-unassigned] [Bug 59743] DRT fails to build perl support in mac production

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59743


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91564|review?                     |review-
               Flag|                            |




--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2011-04-28 15:25:06 PST ---
(From update of attachment 91564)
View in context: https://bugs.webkit.org/attachment.cgi?id=91564&action=review

Marking as r- as the destination path is not correct.

> Tools/ChangeLog:6
> +        Add an install target for production builds.

You can put this on a single line.

> Tools/ChangeLog:8
> +        * DumpRenderTree/mac/PerlSupport/Makefile:

You’re missing a blank line after this.

> Tools/DumpRenderTree/mac/PerlSupport/Makefile:78
> +INSTALL_PATH=/System/Library/Frameworks

I don’t like the name INSTALL_PATH for this since INSTALL_PATH in Xcode configuration settings means something different.  It wouldn’t hurt to use SYSTEM_LIBRARY_DIR in place of the hard-coded /System/Library here either.  And if you’re going to pull the base of the destination directory out in to an environment variable, I’d suggest pulling all of it rather than just a subset from the middle.

> Tools/DumpRenderTree/mac/PerlSupport/Makefile:82
> +	cp $(PERL_MODULE) $(NEXT_ROOT)/$(INSTALL_PATH)/$(WEBKIT_FRAMEWORK_RESOURCES_PATH)/DumpRenderTreeSupport.pm

This isn’t right.  Files need to be installed below DSTROOT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.