[Webkit-unassigned] [Bug 59745] New: Sharing strings across threads now always require copies the 1st time.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59745

           Summary: Sharing strings across threads now always require
                    copies the 1st time.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: levin at chromium.org
                CC: ap at webkit.org, barraclough at apple.com,
                    levin at chromium.org, dslomov at google.com


Strings are suppose to move across thread without copies but this got broken when the StringImpl internal buffer support got added.

Gavin has some good ideas about how to fix this:

1. If I understand correctly, we would change StringImpl::deref so that it didn't do delete a StringImpl was shared and make it so that in the BufferShared case it pointed to the buffer part of a StringImpl which is BufferInternal.

2. Alternatively we could always allocate a separate buffer for large strings.

The first approach is only slightly more complicated but seems more efficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.