[Webkit-unassigned] [Bug 59699] Global object is recreated on teardown, for no good reason

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 11:39:10 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59699


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91486|                            |review-
               Flag|                            |




--- Comment #3 from Geoffrey Garen <ggaren at apple.com>  2011-04-28 11:39:10 PST ---
(From update of attachment 91486)
I think this patch would crash, because setWindow(JSGlobalData&, JSDOMWindow*) assumes the window is not NULL.

It might work to change setWindow(JSGlobalData&, JSDOMWindow*) to use jsNull() as the window shell's prototype if the JSDOMWindow* is NULL, or you could just change setWindow(JSGlobalData&, JSDOMWindow*) to take an explicit prototype argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list