[Webkit-unassigned] [Bug 59143] Need populate touch-icon url to FrameLoaderClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59143


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #10 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-04-28 09:35:08 PST ---
Attachment 91503 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
(  [whitespace/parens] [5]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:59:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:58:  Missing space before ( in switch(  [whitespace/parens] [5]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:74:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:75:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:76:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:78:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:78:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:79:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:81:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:81:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:84:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebKit/chromium/src/WebIconTypeUtilities.cpp:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/IconURL.h:69:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/loader/FrameLoader.h:437:  The parameter name "iconType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoader.h:438:  The parameter name "iconType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoader.cpp:476:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/loader/FrameLoader.cpp:499:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/loader/FrameLoader.cpp:514:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/loader/FrameLoader.cpp:526:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 38 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.