[Webkit-unassigned] [Bug 58613] IndexedDB put() should fail if second (key) parameter is null

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58613





--- Comment #4 from Hans Wennborg <hans at chromium.org>  2011-04-28 04:18:34 PST ---
(In reply to comment #3)
> Straightforward fix -- if key is not specified, the prpKey ends up as a null pointer in ::put(). However, if the key is specified but is null, the prpKey ends up as a valid IDBKey which has a null key type. As it happens, we need to be able to detect the difference between these cases (the key arg is optional but if specified must not be null), and we can! Yay.
> 
> There was one existing layouttest that needed tweaking, plus the new layouttest ported from Mozilla's test suite. All other existing layouttests pass, including 5 that use put() without the second (key) arg. (I know it's exactly 5 because my first attempt crashed these 5 tests.)

Thanks, Mark!

Unofficial r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.