[Webkit-unassigned] [Bug 59369] Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test

Wed Apr 27 19:07:58 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59369

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91407|review?                     |review-
               Flag|                            |

--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-27 19:07:58 PST ---
(From update of attachment 91407)
View in context: https://bugs.webkit.org/attachment.cgi?id=91407&action=review

> LayoutTests/fast/events/mouseout-dead-node.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Please use HTML5 style <!DOCTYPE html>

> LayoutTests/fast/events/mouseout-dead-node.html:11
> +<div onmouseout='testFailed("mouseout")'  onmouseover='document.getElementById("d0").innerHTML ="you should see PASS below"'>

I would have done: this.parent.innerHTML="~~".

> LayoutTests/fast/events/mouseout-dead-node.html:33
> +if (!window.eventSender)
> +    return;

This won't work. I guess you'll have to put everything in an if clause.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.