[Webkit-unassigned] [Bug 59435] REGRESSION (74971): Can't select a line of RTL text on Facebook

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59435





--- Comment #11 from Xiaomei Ji <xji at chromium.org>  2011-04-27 18:47:39 PST ---
(In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > I attached this simple html with a <p> and <div> (no <br>), 
> > > but the selection is not correct in the ways that:
> > > 1. select from left to right, you can not select the rightmost character.
> > > 2. select from rightmost to left, you can not select the rightmost character.
> > 
> > This should be a separate bug.
> 
> I think you are right. This bug is about "selection is cleared", not "selection is mis-placed".
> 
> Then, I do not know whether it is caused by 74971. Sorry for the false alarm.

You might be right about the <br> in comment #6. 
But blindly removing the offset swapping at line 1165 in http://trac.webkit.org/changeset/74971/trunk/WebCore/rendering/InlineTextBox.cpp will make your demo test case work (selection could select the whole line).

I am wondering whether the logical at line 1165 is correct or could be as simple as that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.