[Webkit-unassigned] [Bug 58210] webkit should implement the dropzone attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58210





--- Comment #15 from Daniel Cheng <dcheng at chromium.org>  2011-04-27 17:58:32 PST ---
(From update of attachment 91375)
View in context: https://bugs.webkit.org/attachment.cgi?id=91375&action=review

> Source/WebCore/dom/Clipboard.cpp:164
> +    if (files()->isEmpty())

My comment about saving the return value of files() in a RefPtr still applies. If FileList has n entries, FileList will be created 2n + 1 times through this function if nothing matches.

> Source/WebCore/dom/Clipboard.cpp:176
> +    bool ok;

On some platforms, querying the types in a drag is not expensive but retrieving the data might be. It is probably better to use types().contains().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.