[Webkit-unassigned] [Bug 59571] [JSC] Nodes in shadow DOM should not be GCed while their hosts are alive and they have JS properties

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 17:10:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59571





--- Comment #8 from Geoffrey Garen <ggaren at apple.com>  2011-04-27 17:10:51 PST ---
> What do you recommend as a robust way to make the thread roots reflect the state of variables in the script?

Our typical solution is to test a few different elements in a loop. So, put 10 'p' elements in an array, ensureShadowRoot and tatoo each of them in a loop, gc, and then test all 10 shadow roots for the tatoo in a loop. Since the same code tatoos each element, it's extremely likely -- pretty much guaranteed -- to overwrite old references with new references, leaving at least some of the tested elements completely unreferenced.

So, to clarify what I think is needed here:

1. Early return after calling GCController.collect if GCController exists.

2. A looping test that would fail on Mac without your change, but passes with your change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list