[Webkit-unassigned] [Bug 59414] Implement CSS border width and related properties in CSSStyleApplyProperty.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59414





--- Comment #16 from Luke Macpherson <macpherson at chromium.org>  2011-04-27 16:04:37 PST ---
(In reply to comment #15)
> (In reply to comment #11)
> > (From update of attachment 91221 [details] [details])
> > It's confusing to have ApplyPropertyDefault and DefaultBase, why the distinction?
> > The same question applies to all of the existing classes in CSSStyleApplyProperty..
> > Why have ApplyPropertColor -> ApplyPropertyColorBase -> ApplyPropertyBase - I don't see the need for the extra level FooBarBase.
> > Can we please focus first on cleaning up CSSStyleApplyProperty, before adding new classes...
> 
> The reason is that ApplyPropertyBase casts a CSSPrimitiveValue to T in applyValue(). That is not always a valid thing to do, so the compiler complains. That is the reason for the separation in this case. I would have liked to avoid it, but it wasn't possible in this case. This was briefly explained in the changelog entry.

s/ApplyPropertyBase/ApplyPropertyDefaultValue

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.