[Webkit-unassigned] [Bug 58806] float:right content positioned too low after display:inline content due to whitespace

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 15:45:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58806





--- Comment #20 from Levi Weintraub <leviw at google.com>  2011-04-27 15:45:35 PST ---
(From update of attachment 90427)
View in context: https://bugs.webkit.org/attachment.cgi?id=90427&action=review

This seems like a valid fix, but like you said, the patch on bug 45274 appears simpler so I'd lean towards that approach. That said, I'd want your layout tests rolled into the other patch, as you appear to cover more cases (and fix the three tests that need an extra character to yield the same results :)

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1733
> +    Vector<RenderObject*> trailingFloatingBoxes;
> +    Vector<FloatingObject*> trailingFloatingObjects;

I suspect we'd want to reserve space here to avoid mallocing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list