[Webkit-unassigned] [Bug 54929] REGRESSION: Text selection broken for text with line-height applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54929





--- Comment #15 from Levi Weintraub <leviw at chromium.org>  2011-04-27 15:20:13 PST ---
(From update of attachment 85560)
View in context: https://bugs.webkit.org/attachment.cgi?id=85560&action=review

>> Source/WebCore/ChangeLog:9
>> +        associated InlineTextBoxes. This negative value won't necessarily result in a point the RenderText 
> 
> Is ever having a negative logicalTop a bug? Shouldn't logicalTop always be non-negative? I don't actually know. Hyatt?

Perhaps this is the bug, I don't know. It does render correctly.

>> Source/WebCore/rendering/RenderBlock.cpp:4077
>> +        IntPoint point(pointInLogicalContents.x(), closestBox->isText() ? closestBox->root()->selectionTop() : closestBox->logicalHeight());
> 
> The selectionTop of the rootlinebox is not necessarily inside the closestBox, is it? As in, what if the closestBox is on the second line?

The RootInlineBox always owns just one line, so it'll always contain its InlineBox children.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.