[Webkit-unassigned] [Bug 59249] Colliding isinf/isnan between C99 and C++0x with GCC 4.6.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59249


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90792|review?                     |review-
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2011-04-27 13:45:19 PST ---
(From update of attachment 90792)
View in context: https://bugs.webkit.org/attachment.cgi?id=90792&action=review

>>> Source/JavaScriptCore/ChangeLog:9
>>> +        used, since it can lead to ambiguity in C++0x compilers. See the
>> 
>> This is not a very maintainable rule, and following it makes the code base less consistent. I hope that there is a better solution.
>> 
>> Is this a gcc bug, or expected behavior?
> 
> I can't really think of any, but there might be. My proposed long-term solution of getting rid of math.h and always using std:: in front of the functions also requires not to use "using namespace std;", at least in the files where isnan/isinf are called, so it wouldn't be a huge improvement in that regard, I suppose.

The right thing to do is to find a fix in MathExtras.h. The goal is to be able to call isinf and isnan directly; there must be way to do that.

Please do *not* start making these changes to all the files using MathExtras.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.