[Webkit-unassigned] [Bug 59601] [GTK] Do not initialize wep application database if it was disabled at configure time.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59601


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91270|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-04-27 13:36:41 PST ---
(From update of attachment 91270)
View in context: https://bugs.webkit.org/attachment.cgi?id=91270&action=review

Very nice. One small suggestion below.

> Source/WebKit/gtk/webkit/webkitglobals.cpp:271
>      gchar* databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL);
>      webkit_set_web_database_directory_path(databaseDirectory);
>      WebCore::cacheStorage().setCacheDirectory(databaseDirectory);
>  
>      g_free(databaseDirectory);

Please switch to using GOwnPtr for databaseDirectory:

GOwnPtr<gchar> databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL);
webkit_set_web_database_directory_path(databaseDirectory.get());
WebCore::cacheStorage().setCacheDirectory(databaseDirectory.get());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.