[Webkit-unassigned] [Bug 59369] Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test

Wed Apr 27 12:47:29 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59369


--- Comment #14 from Naoki Takano <takano.naoki at gmail.com>  2011-04-27 12:47:29 PST ---
Thank you for your review every time!!

(In reply to comment #13)
> (From update of attachment 91235 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91235&action=review
> 
> > LayoutTests/fast/events/mouseout-dead-node.html:1
> > +<link rel="stylesheet" href="../js/resources/js-test-style.css">
> 
> No DOCTYPE / head?
I'll add it.

> > LayoutTests/fast/events/mouseout-dead-node.html:4
> >  <body onload='test()'>
> 
> I don't think there's any need to wait until page load.
> 
> > LayoutTests/fast/events/mouseout-dead-node.html:15
> > +    <div id=d0 style='border:2px solid red'>
> > +        <div onmouseout='testFailed("mouseout")'  onmouseover='document.getElementById("d0").innerHTML ="you should see PASS below"'>
> > +            <div onmouseout='testFailed("mouseout")'>
> > +                <span id=target1 onmouseout='testPassed("mouseout")' >
> > +                    mouse over me
> > +                </span>
> > +            </div>
> 
> I don't think we need to indent each element like this.
Ok, so do I have to erase whole indent for html element?

> > LayoutTests/fast/events/mouseout-dead-node.html:32
> >  function test() {
> 
> You don't need this function. You can just run the script as it's parsed.
I will erase onload.

> > LayoutTests/fast/events/mouseout-dead-node.html:54
> > +description("Test that if node dies under mouse it receives mouseout event but that the event does not propagate.");
> 
> Please move this above the test code so that people reading the test code can understand the intent of this test before reading the code.
Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.