[Webkit-unassigned] [Bug 59571] [JSC] Nodes in shadow DOM should not be GCed while their hosts are alive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59571


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91208|review?                     |review-
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2011-04-27 11:58:36 PST ---
(From update of attachment 91208)
View in context: https://bugs.webkit.org/attachment.cgi?id=91208&action=review

It looks like your patch doesn't include any new test results. If we're going to make this change, I think we need a test with results that vary depending on whether this change is in the tree.

> LayoutTests/fast/dom/shadow/gc-shadow.html:19
> +    // Some ports (unfortunately) take GCController.collect as advisory.
> +    for (var i = 0; i < 10000; i++)
> +        var s = new String(i);

Which ports take GCController.collect as advisory?

If there is a port like that, it's broken. I don't think we should make this test 2-3X slower on all ports just because some ports are broken. If window.GCController is defined, we should call collect() and return early.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.