[Webkit-unassigned] [Bug 59580] Extract KeyboardEventHandler from EventHandler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59580


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org
                   |kit.org                     |
  Attachment #91229|                            |review?
               Flag|                            |




--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-26 22:09:38 PST ---
Created an attachment (id=91229)
 --> (https://bugs.webkit.org/attachment.cgi?id=91229&action=review)
work in progress

Here's a work in progress patch (r? only because I want EWS to find build errors)

Sam & Alexey, could you tell me what CurrentEventScope is trying to do in EventHandlerMac.mm?  I removed EventHandler::keyEvent(NSEvent*) and replaced call sites in WebHTMLView.mm by keyEvent(PlatformKeyboardEvent(event)) but I didn't add CurrentEventScope in those places.  Should I be adding them?  As far as I looked at the definition of CurrentEventScope, they only seem to have a retain pointer for NSEvent which makes me think that the code is there only to resolve some binding issues between C++ and Objective-C but I'm entirely sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.