[Webkit-unassigned] [Bug 59561] Switch TestWebKitAPI to GTest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 17:13:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59561





--- Comment #1 from Dmitry Lomov <dslomov at google.com>  2011-04-26 17:13:48 PST ---
Created an attachment (id=91192)
 --> (https://bugs.webkit.org/attachment.cgi?id=91192&action=review)
Draft attempt

This is a very first draft. It switches the all tests to GTest, retaining the functionality. Output format is a bit different though, and test names use '.' instead of '/' (WTF.VectorBasic instead of WTF/VectorBasic).
Only builds on Mac yet.

As you see, the change is very small. I have not replaced all the assertion macros, merely redefined existing ones in terms of GTest. By a lucky coincidence, the TEST macro works unchanged.

Here is some work items to be done before this can be landed:
0) Clean up project files on Mac 
1) Build on Windows 
2) Run on bots (what is the current story with TestWebKitAPI on bots? Are those tests run on bots on any platform?) 

Sam, is (1) a priority for you?

After this lands, we might want to make tests more GTest-idiomatic by:
a) Using GTest macros throughout
b) Using GTest fixtures and SetUp/TearDown instead of statics

Let me know what you think!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list