[Webkit-unassigned] [Bug 58905] [Qt][Texmap] Do not create a texture if it will not be used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58905


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90215|review?                     |review-
               Flag|                            |




--- Comment #3 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-04-26 17:13:03 PST ---
(From update of attachment 90215)
View in context: https://bugs.webkit.org/attachment.cgi?id=90215&action=review

Overall change looks good, r- to fix the typo and change come up with a better function name.

> Source/WebCore/ChangeLog:14
> +        No new tests required as no functionaliry changes.

Typo.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:176
> +    inline bool shouldBePainted() const

I think we should have a more descriptive name - what about haveContent() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.