[Webkit-unassigned] [Bug 57948] JSC bindings generator: support non-object numbers as callback arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57948


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88576|review?                     |review-
               Flag|                            |




--- Comment #13 from Maciej Stachowiak <mjs at apple.com>  2011-04-26 17:04:39 PST ---
(From update of attachment 88576)
View in context: https://bugs.webkit.org/attachment.cgi?id=88576&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2290
>> +                    push(@implContent, "    args.append(jsNumber(static_cast<$paramType>(${paramName})));\n");
> 
> Why the static_cast? The code should work fine, perhaps better, without it.

Indeed, the static_cast seems wrong in all places that its used so r- for that. Please revise and resubmit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.