[Webkit-unassigned] [Bug 56855] [GTK] Provide a way in DRT to check the platform name

Tue Apr 26 16:59:07 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56855

Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88635|review?                     |review-
               Flag|                            |

--- Comment #12 from Adam Roben (:aroben) <aroben at apple.com>  2011-04-26 16:59:07 PST ---
(From update of attachment 88635)
View in context: https://bugs.webkit.org/attachment.cgi?id=88635&action=review

You should add a test that shows this is working. You should also explain why this is needed.

> Tools/DumpRenderTree/LayoutTestController.cpp:2093
> +    return JSValueMakeString(context, controller->platformName());

This is leaking the JSStringRef returned by platformName. platformName should return a JSRetainPtr<JSStringRef> instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.