[Webkit-unassigned] [Bug 57731] [CSS 3] missing cursor support for 'none' on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:43:13 PDT 2011


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
  Attachment #88773|review?                     |review-
               Flag|                            |

--- Comment #10 from Maciej Stachowiak <mjs at apple.com>  2011-04-26 16:43:13 PST ---
(From update of attachment 88773)
View in context: https://bugs.webkit.org/attachment.cgi?id=88773&action=review

See Adam's suggestions in a previous comment. Further comments below. Please revise and resubmit.

> Source/WebKit2/UIProcess/win/WebView.cpp:1011
> +    // It's ok if m_lastCursorSet is null:
> +    // that's how Cursor::None is represented.

This comment seems unnecessary, you don't have to explain the lack of a special case.

> Source/WebKit2/UIProcess/win/WebView.cpp:1020
> +    // It's ok if m_webCoreCursor is null:
> +    // that's how Cursor::None is represented.

Also here. Particularly, having the comment a second time seems unnecessary,

> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:800
> +    // It's ok if platformCursor is null:
> +    // that's how Cursor::None is represented.

And here too, I would drop the comment.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list