[Webkit-unassigned] [Bug 59234] CrossThreadCopier should not have a default specialization for raw pointers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:30:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59234


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90931|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2011-04-26 16:30:51 PST ---
(From update of attachment 90931)
View in context: https://bugs.webkit.org/attachment.cgi?id=90931&action=review

> Source/WebCore/fileapi/FileReader.cpp:133
> +        scriptExecutionContext()->postTask(
> +            createCallbackTask(&delayedStart, AllowExtendedLifetime(this)));

webkit has no column limit.

> Source/WebCore/platform/CrossThreadCopier.h:142
> +    template<typename T> struct AllowExtendedLifetimeWrapper {
> +      public:
> +        explicit AllowExtendedLifetimeWrapper(T* value) : m_value(value) { }
> +        T* value() const { return m_value; }
> +      private:
> +        T* m_value;
> +    };

4 space indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list