[Webkit-unassigned] [Bug 59078] Reftests should be skipped if pixel tests are disabled.

Tue Apr 26 16:27:00 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59078

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90690|review?                     |review-
               Flag|                            |

--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2011-04-26 16:27:00 PST ---
(From update of attachment 90690)
View in context: https://bugs.webkit.org/attachment.cgi?id=90690&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py:254
> +            reftests_files = set(test_file for test_file in self._test_files if self._port.is_reftest(test_file))
> +            self._printer.print_expected('%d reftests will be skipped because pixel tests are disabled.' % len(reftests_files))
> +            self._test_files -= reftests_files

This is a lot of file-system reading just to determine a small number of tests to read. The problem is that we're blocking running any tests on this. I'd rather we not spit out the number of tests skipped and instead skip the test when we're about to run it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.