[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78699|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #37 from Adam Barth <abarth at webkit.org>  2011-04-26 16:25:00 PST ---
(From update of attachment 78699)
View in context: https://bugs.webkit.org/attachment.cgi?id=78699&action=review

Ok.  I think it's time for this patch now.  Some minor nits below.

> Source/WebCore/html/HTMLLinkElement.h:76
> +    // from LinkLoaderClient

We don't really need this comment.

> Source/WebCore/loader/LinkLoaderClient.h:44
> +    virtual ~LinkLoaderClient();

Do we need this?  No one should be deleting subclasses via this pointer, right?

> Source/WebCore/loader/LinkLoaderClient.h:47
> +    virtual void linkLoaded();
> +    virtual void linkError();

It seems like these should be pure virtual.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.