[Webkit-unassigned] [Bug 54929] REGRESSION: Text selection broken for text with line-height applied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:17:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=54929


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85560|review?                     |review-
               Flag|                            |




--- Comment #13 from Ojan Vafai <ojan at chromium.org>  2011-04-26 16:17:18 PST ---
(From update of attachment 85560)
View in context: https://bugs.webkit.org/attachment.cgi?id=85560&action=review

> Source/WebCore/ChangeLog:9
> +        When an InlineBox has a line-height smaller than its actual height it results in a negative logicalTop for
> +        associated InlineTextBoxes. This negative value won't necessarily result in a point the RenderText 

Is ever having a negative logicalTop a bug? Shouldn't logicalTop always be non-negative? I don't actually know. Hyatt?

> Source/WebCore/rendering/RenderBlock.cpp:4077
> +        IntPoint point(pointInLogicalContents.x(), closestBox->isText() ? closestBox->root()->selectionTop() : closestBox->logicalHeight());

The selectionTop of the rootlinebox is not necessarily inside the closestBox, is it? As in, what if the closestBox is on the second line?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list