[Webkit-unassigned] [Bug 59465] Port Mozilla's IndexedDB tests: readonly and read/write transactions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59465





--- Comment #2 from David Grogan <dgrogan at chromium.org>  2011-04-26 16:16:24 PST ---
(From update of attachment 91120)
View in context: https://bugs.webkit.org/attachment.cgi?id=91120&action=review

Substance is good, just style stuff

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readonly-transactions.html:47
> +function cleanDatabase()

Make more accurate/descriptive.  You can probably ignore the deleteAllObjectStores calls and instead describe the other stuff they do.

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readonly-transactions.html:51
> +    osName = "test store";

I think the Webkit Way is to abbreviate as little as possible.  rename osName -> objectStoreName

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readwrite-transactions.html:26
> +    indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");

at some point we should probably refactor some or all of this into a function that lives in resources/shared.js

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readwrite-transactions.html:49
> +function cleanDatabase()

same comment as usual about cleanDatabase

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readwrite-transactions.html:63
> +    key1 = evalAndLog("key1 = event.target.result;");

move this to postAdd2, right before key1 is first used

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readwrite-transactions.html:72
> +    key2 = evalAndLog("key2 = event.target.result;");

move this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.