[Webkit-unassigned] [Bug 47769] [chromium] Keyboard+mouse selection in select popups only updated after unfocused

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 15:53:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=47769


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81604|review?                     |review-
               Flag|                            |




--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2011-04-26 15:53:14 PST ---
(From update of attachment 81604)
View in context: https://bugs.webkit.org/attachment.cgi?id=81604&action=review

Just one concern. Otherwise the patch looks fine.

> Source/WebKit/chromium/src/WebViewImpl.cpp:570
> +    // If there is a select popup, it should be the one processing the event,
> +    // not the page.
> +    if (m_selectPopup)
> +        return m_selectPopup->handleKeyEvent(PlatformKeyboardEventBuilder(event));

seems like this should be after we set m_suppressNextKeypressEvent to false, no?

> Source/WebKit/chromium/src/WebViewImpl.cpp:687
> +    // If there is a select popup, it should be the one processing the event,
> +    // not the page.
> +    if (m_selectPopup)
> +        return m_selectPopup->handleKeyEvent(PlatformKeyboardEventBuilder(event));

seems like this should be after we set m_suppressNextKeypressEvent to false, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list