[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #46 from Antonio Gomes <tonikitoo at webkit.org>  2011-04-26 15:51:20 PST ---
(From update of attachment 84026)
View in context: https://bugs.webkit.org/attachment.cgi?id=84026&action=review

Please reply to Gyuyoung's questions, and mine as well. A few style issues to be fixed, and it does not apply to ToT anymore (rebase needed).

> Source/WebKit/efl/ewk/ewk_settings.cpp:332
> +    WebCore::MemoryCache *cache = WebCore::memoryCache();

"*" is on the left side.

> Source/WebKit/efl/ewk/ewk_settings.h:54
> +EAPI Eina_Bool       ewk_settings_cache_disable_set(Eina_Bool set);

Is it common to have "disable_set" APIs instead of "enable_set"?

> Source/WebKit/efl/ewk/ewk_view.cpp:4439
> +    return (result_cookies && result_cache && result_offline_pages);

no parentheses needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.