[Webkit-unassigned] [Bug 58614] IndexedDB delete() should fail if key is null

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58614





--- Comment #3 from David Grogan <dgrogan at chromium.org>  2011-04-26 15:45:49 PST ---
(From update of attachment 91097)
View in context: https://bugs.webkit.org/attachment.cgi?id=91097&action=review

Code LG, just nits.

> third_party/WebKit/Source/WebCore/ChangeLog:5
> +        IndexedDB object store delete should fail if key is null

make more obvious that you're referring to an object store deleting an entry, not an entire object store being deleted. e.g. myObjectStore.delete(null)

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/key-requirements-delete-null-key.html:45
> +function cleanDatabase()

Change to something not misleading, e.g. cleanDatabaseAndCreateObjectStore or just inSetVersion

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.